openerp-community-reviewer team mailing list archive

[Stéphane Bidoul (Acsone) <stephane.bidoul@xxxxxxxxx>]

Stéphane Bidoul (Acsone) has proposed merging lp:~acsone-openerp/web-addons/web_easy_switch_company-userform-fix-sbi into lp:web-addons.

Requested reviews:
  Web-Addons Core Editors (webaddons-core-editors)

For more details, see:
https://code.launchpad.net/~acsone-openerp/web-addons/web_easy_switch_company-userform-fix-sbi/+merge/216170

web_easy_switch_company removes the company_id field from the user preferences form.

Some module extending the form and relying on the presence of that field break when web_easy_switch_company (sale_crm for instance).

This MP fixes this by hiding the field instead of removing it.

-- 
https://code.launchpad.net/~acsone-openerp/web-addons/web_easy_switch_company-userform-fix-sbi/+merge/216170
Your team Web-Addons Core Editors is requested to review the proposed merge of lp:~acsone-openerp/web-addons/web_easy_switch_company-userform-fix-sbi into lp:web-addons.

=== modified file 'web_easy_switch_company/view/res_users_view.xml'
--- web_easy_switch_company/view/res_users_view.xml	2014-03-10 20:13:54 +0000
+++ web_easy_switch_company/view/res_users_view.xml	2014-04-16 17:59:26 +0000
@@ -8,7 +8,9 @@
             <field name="inherit_id" ref="base.view_users_form_simple_modif"/>
             <field name="arch" type="xml">
                 <!-- hide old behaviour to change company -->
-                <field name="company_id" position="replace" />
+                <field name="company_id" position="attributes">
+                    <attribute name="invisible">1</attribute>
+                </field>
             </field>
         </record>
     </data>