openerp-community-reviewer team mailing list archive

[Lionel Sausin - Numérigraphe <ls@xxxxxxxxxxxxxxxx>]

Lionel Sausin - Numérigraphe has proposed merging lp:~numerigraphe-team/report-print-send/7.0-default-bool-required-lp1308614-ls into lp:report-print-send.

Requested reviews:
  Report Printing and Sending Core Editors (report-print-send-core-editors)
Related bugs:
  Bug #1308614 in Report - Printing and Sending: ""set default" on printers does not work in base_report_to_printer v7"
  https://bugs.launchpad.net/report-print-send/+bug/1308614

For more details, see:
https://code.launchpad.net/~numerigraphe-team/report-print-send/7.0-default-bool-required-lp1308614-ls/+merge/216354

The "set default" button on printers selects a single default printer, but it does not work in v7 because the field is marked "required" and this is deprecated for booleans in v7.
-- 
https://code.launchpad.net/~numerigraphe-team/report-print-send/7.0-default-bool-required-lp1308614-ls/+merge/216354
Your team Report Printing and Sending Core Editors is requested to review the proposed merge of lp:~numerigraphe-team/report-print-send/7.0-default-bool-required-lp1308614-ls into lp:report-print-send.

=== modified file 'base_report_to_printer/printing.py'
--- base_report_to_printer/printing.py	2013-12-27 18:43:25 +0000
+++ base_report_to_printer/printing.py	2014-04-17 16:02:55 +0000
@@ -45,7 +45,7 @@
     _columns = {
         'name' : fields.char('Name',size=64,required=True,select="1"),
         'system_name': fields.char('System Name',size=64,required=True,select="1"),
-        'default':fields.boolean('Default Printer',required=True,readonly=True),
+        'default':fields.boolean('Default Printer', readonly=True),
         'status': fields.selection([('unavailable','Unavailable'),('printing','Printing'),('unknown','Unknown'),('available','Available'),('error','Error'),('server-error','Server Error')], 'Status', required=True, readonly=True),
         'status_message': fields.char('Status Message', size=500, readonly=True),
         'model': fields.char('Model', size=500, readonly=True),