openerp-community-reviewer team mailing list archive

[Alexandre Fayolle - camptocamp <alexandre.fayolle@xxxxxxxxxxxxxx>]

Alexandre Fayolle - camptocamp has proposed merging lp:~camptocamp/ocb-web/7.0-fix_1190236_opw-595981-msh into lp:ocb-web.

Requested reviews:
  OpenERP Community Backports Team (ocb)
Related bugs:
  Bug #1190236 in OpenERP Community Backports (Web): "Kanban view doesn't show constraint error message"
  https://bugs.launchpad.net/ocb-web/+bug/1190236

For more details, see:
https://code.launchpad.net/~camptocamp/ocb-web/7.0-fix_1190236_opw-595981-msh/+merge/216664

Fixed the issue of kanban not shows exception message, instead it shows static message, rpc fail already shows error popup so there is not need of special alert.

Demo: Override write for any object for which kanban view is developed, raise exception with your message from write, move kanban box from one state to another so that exception raised.

Result: Alert box instead of error popup.
Expected: error popup should come with defined message.

Port of https://code.launchpad.net/~openerp-dev/openerp-web/7.0-opw-595981-msh/+merge/177740 to OCB
-- 
https://code.launchpad.net/~camptocamp/ocb-web/7.0-fix_1190236_opw-595981-msh/+merge/216664
Your team OpenERP Community Backports Team is requested to review the proposed merge of lp:~camptocamp/ocb-web/7.0-fix_1190236_opw-595981-msh into lp:ocb-web.

=== modified file 'addons/web_kanban/static/src/js/kanban.js'
--- addons/web_kanban/static/src/js/kanban.js	2014-01-17 10:19:43 +0000
+++ addons/web_kanban/static/src/js/kanban.js	2014-04-22 06:34:58 +0000
@@ -424,8 +424,6 @@
                 record.do_reload();
                 new_group.do_save_sequences();
             }).fail(function(error, evt) {
-                evt.preventDefault();
-                alert(_t("An error has occured while moving the record to this group: ") + data.fault_code);
                 self.do_reload(); // TODO: use draggable + sortable in order to cancel the dragging when the rcp fails
             });
         }