openerp-community-reviewer team mailing list archive

[Alexandre Fayolle - camptocamp <alexandre.fayolle@xxxxxxxxxxxxxx>]

Alexandre Fayolle - camptocamp has proposed merging lp:~camptocamp/ocb-addons/6.1-fix_1311004_account_move_line_index-afe into lp:ocb-addons/6.1.

Requested reviews:
  OpenERP Core Team (openerp)
  Guewen Baconnier @ Camptocamp (gbaconnier-c2c): code review
  Yannick Vaucher @ Camptocamp (yvaucher-c2c)
Related bugs:
  Bug #1311004 in OpenERP Community Backports (Addons): "missing database index on account_move_line(date, id)"
  https://bugs.launchpad.net/ocb-addons/+bug/1311004

For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/6.1-fix_1311004_account_move_line_index-afe/+merge/216820

improve reading account_move_lines by using an index on date, id matching _order

port of https://code.launchpad.net/~camptocamp/openobject-addons/6.1-fix_1311004_account_move_line_index-afe/+merge/216687 to OCB (6.1)
-- 
https://code.launchpad.net/~camptocamp/ocb-addons/6.1-fix_1311004_account_move_line_index-afe/+merge/216820
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons/6.1.

=== modified file 'account/account_move_line.py'
--- account/account_move_line.py	2012-09-06 14:35:17 +0000
+++ account/account_move_line.py	2014-04-23 06:23:18 +0000
@@ -567,6 +567,9 @@
         cr.execute('SELECT indexname FROM pg_indexes WHERE indexname = \'account_move_line_journal_id_period_id_index\'')
         if not cr.fetchone():
             cr.execute('CREATE INDEX account_move_line_journal_id_period_id_index ON account_move_line (journal_id, period_id)')
+        cr.execute('SELECT indexname FROM pg_indexes WHERE indexname = %s', ('account_move_line_date_id_index',))
+        if not cr.fetchone():
+            cr.execute('CREATE INDEX account_move_line_date_id_index ON account_move_line (date DESC, id desc)')
 
     def _check_no_view(self, cr, uid, ids, context=None):
         lines = self.browse(cr, uid, ids, context=context)