openerp-community-reviewer team mailing list archive

[Romain Deheele - Camptocamp <romain.deheele@xxxxxxxxxxxxxx>]

Romain Deheele - Camptocamp has proposed merging lp:~camptocamp/openerp-rma/rma-fix-lp1311509_rde into lp:openerp-rma.

Requested reviews:
  OpenERP RMA (openerprma)
Related bugs:
  Bug #1311509 in OpenERP RMA: "Error when we try to create a refund"
  https://bugs.launchpad.net/openerp-rma/+bug/1311509

For more details, see:
https://code.launchpad.net/~camptocamp/openerp-rma/rma-fix-lp1311509_rde/+merge/216824

Hi,

It fixes https://bugs.launchpad.net/openerp-rma/+bug/1311509 : error at refund generation.

Line records in context are in this form : [[4, 1, False], [4, 2, False]].
We need to take in account the third element in each list when we fetch lines.

Regards,

Romain
-- 
https://code.launchpad.net/~camptocamp/openerp-rma/rma-fix-lp1311509_rde/+merge/216824
Your team OpenERP RMA is requested to review the proposed merge of lp:~camptocamp/openerp-rma/rma-fix-lp1311509_rde into lp:openerp-rma.

=== modified file 'crm_claim_rma/account_invoice.py'
--- crm_claim_rma/account_invoice.py	2014-02-18 10:34:22 +0000
+++ crm_claim_rma/account_invoice.py	2014-04-23 08:02:03 +0000
@@ -46,7 +46,7 @@
             return super(account_invoice, self)._refund_cleanup_lines(
                 cr, uid, lines, context=None)
 
-        for __, claim_line_id in context.get('claim_line_ids'):
+        for __, claim_line_id, __ in context.get('claim_line_ids'):
             line = claim_line_obj.browse(cr, uid, claim_line_id,
                                          context=context)
             if not line.refund_line_id: