openerp-community-reviewer team mailing list archive

[Daniel Reis <dgreis@xxxxxxx>]

Review: Needs Fixing

Excellent addition. In fact, so good I'm trying it out in a production instance :-)

Comments and suggestions:

L68: Explain in description that the Database scheduled logging must be manually activated.
L73: Explain that logs can be viewed through menu Reporting -> Server Monitoring.
L671: the server.monitor.process table will grow rapidly, so maybe it would be nice to gave some indexes. I suggest: uid, model and create_date.
L685: the 'info' field is either "rpc call" or "cron job". Wouldn't a selection field be more efficient here?
L697: CPU is for current request, and Memory is for current server process, right? This should be explained somewhere, wither in the views or in the module description.
L756: option to disable Server Process log_measure is not available yet, correct?
L771: I worry about this extra search to translate model_name into model_id. Why not store model_name directly?
L778: I see that 'status' is kept empty; is this intended to store WARNING and ERROR results? That would be an excellent addition.
L1146: for Process logs, would it be possible to add an option to group by day? (currently group by month, which is insufficient...)
L1388: fix menu option name form "DB Rows" to "DB Writes"

Again, great work!
-- 
https://code.launchpad.net/~camptocamp/server-env-tools/7.0-monitoring/+merge/215138
Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools.