openerp-community-reviewer team mailing list archive

[Alexandre Fayolle - camptocamp <alexandre.fayolle@xxxxxxxxxxxxxx>]

Review: Needs Fixing code review, no test

Your SQL request maybe works but it is not written in an efficient way (2 DISTINCT, 1 subquery). This should be written with EXISTS. 

And, each time you bypass the ORM to write raw SQL, $DEITY kills a kitten. $DEITY also maims a puppy if you don't ensure that your code is not blatantly any ir.rules. Did you check for this?
-- 
https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix-store-fields-mdh/+merge/216849
Your team Account Core Editors is subscribed to branch lp:account-budgeting.