openerp-community-reviewer team mailing list archive

[Alex Comba - Agile BG <alex.comba@xxxxxxxxxxx>]

Alex Comba - Agile BG has proposed merging lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl.

Commit message:
[FIX] bug #1312024

Requested reviews:
  Purchase Core Editors (purchase-core-editors)

For more details, see:
https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061

This branch contains the fix for https://bugs.launchpad.net/purchase-wkfl/+bug/1312024 and a bit of flake8 cleanup.
-- 
https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061
Your team Purchase Core Editors is requested to review the proposed merge of lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl.

=== modified file 'product_by_supplier/__openerp__.py'
--- product_by_supplier/__openerp__.py	2014-02-06 19:59:12 +0000
+++ product_by_supplier/__openerp__.py	2014-04-24 14:30:21 +0000
@@ -24,21 +24,27 @@
     'name': 'Product by supplier info',
     'version': '1.0',
     'category': 'purchase',
-    'sequence': 19,
     'summary': 'Show products grouped by suppliers',
     'description': """
+Product Supplier Info
+==================================================
 This module categorizes each product item by supplier.
-======================================================
-* It allows for users to be able to view a compiled list of products supplied \
-by the supplier.
-* Users can also directly add new products to the supplier's list.
-    """,
+It allows for users to be able to view a compiled list
+of products supplied by the supplier.
+
+Users can also directly add new products to the supplier's list.
+
+Contributors
+------------
+
+* Alex Comba <alex.comba@xxxxxxxxxxx>
+""",
     'author': 'Elico Corp',
     'website': 'http://www.elico-corp.com',
-    'images': [
-               'static/images/product_supplier_info.png'
-               ],
-    'depends': ['product', 'stock'],
+    'license': 'AGPL-3',
+    'depends': [
+        'product', 'stock'
+    ],
     'data': [
         'product_view.xml',
     ],

=== modified file 'product_by_supplier/product.py'
--- product_by_supplier/product.py	2013-11-12 01:44:31 +0000
+++ product_by_supplier/product.py	2014-04-24 14:30:21 +0000
@@ -20,7 +20,6 @@
 #
 ##############################################################################
 from openerp.osv import orm, fields
-import openerp.addons.decimal_precision as dp
 
 
 class product_supplierinfo(orm.Model):
@@ -33,7 +32,8 @@
         product_obj = self.pool.get('product.product')
         for record in self.browse(cr, uid, ids, context=context):
             res[record.id] = {}
-            product = product_obj.browse(cr, uid, record.product_id.id, context=context)
+            product = product_obj.browse(
+                cr, uid, record.product_id.id, context=context)
             res[record.id]['qty_available'] = product.qty_available
             res[record.id]['virtual_available'] = product.virtual_available
         return res
@@ -47,10 +47,13 @@
         'virtual_available': fields.function(
             _product_available, multi='virtual_available', type='float',
             string="Forecasted Quantity"),
-        'delay' : fields.integer('Delivery Lead Time', required=True,
-                                 group_operator="avg",
-                                 help="Lead time in days between the confirmation of the purchase order and the reception of the products in your warehouse. Used by the scheduler for automatic computation of the purchase order planning."
-                                 ),
+        'delay': fields.integer(
+            'Delivery Lead Time', required=True, group_operator="avg",
+            help="Lead time in days between the confirmation of the"
+            " purchase order and the reception of the products in your"
+            " warehouse. Used by the scheduler for automatic computation of"
+            " the purchase order planning."
+        ),
     }
 
 # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== modified file 'product_by_supplier/product_view.xml'
--- product_by_supplier/product_view.xml	2014-02-06 19:59:12 +0000
+++ product_by_supplier/product_view.xml	2014-04-24 14:30:21 +0000
@@ -70,6 +70,6 @@
             name="Product by Suppliers"
             sequence="15"
             action="action_product_supplier_info"
-            parent="purchase.menu_procurement_management_product"/>
+            parent="stock.menu_stock_product"/>
     </data>
 </openerp>