openerp-community-reviewer team mailing list archive

["Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>]

Guewen Baconnier @ Camptocamp has proposed merging lp:~camptocamp/lp-community-utils/nag-nameerror-1312682 into lp:lp-community-utils.

Requested reviews:
  Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c): code review, no test
Related bugs:
  Bug #1312682 in OpenERP Launchpad Community Utils: "NameError: global name 'age' is not defined"
  https://bugs.launchpad.net/lp-community-utils/+bug/1312682

For more details, see:
https://code.launchpad.net/~camptocamp/lp-community-utils/nag-nameerror-1312682/+merge/217216

Fix lp:1312682

Restore what we had before revision 30: http://bazaar.launchpad.net/~openerp-community-reviewer/lp-community-utils/openerp-reviewers-nag/view/29/openerp-nag#L213
-- 
https://code.launchpad.net/~camptocamp/lp-community-utils/nag-nameerror-1312682/+merge/217216
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:lp-community-utils.

=== modified file 'openerp-nag'
--- openerp-nag	2014-03-14 16:13:39 +0000
+++ openerp-nag	2014-04-25 11:49:56 +0000
@@ -213,6 +213,7 @@
             )
 
         # Nag about approved merges
+        age = (now - proposal.date_review_requested).days
         if (votes.approve == votes.total(for_approval=True) and
                 (votes.approve >= policy.approvals_to_bypass or
                  votes.approve >= policy.min_approve and