openerp-community-reviewer team mailing list archive

["Laurent Mignon \(Acsone\)" <laurent.mignon@xxxxxxxxx>]

Laurent Mignon (Acsone) has proposed merging lp:~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi into lp:account-financial-report.

Requested reviews:
  Account Report Core Editors (account-report-core-editor)
Related bugs:
  Bug #1312732 in Account - Financial Report: "Plain SQL required for the first install of account_financial_report_webkit is executed at each module update"
  https://bugs.launchpad.net/account-financial-report/+bug/1312732

For more details, see:
https://code.launchpad.net/~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi/+merge/217240

[FIX] lp:1312732
Use the migration machinery to launch the initialization of the newly created column on account_move_line only on the first installation of the module account_financial_report_webkit
-- 
https://code.launchpad.net/~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi/+merge/217240
Your team Account Report Core Editors is requested to review the proposed merge of lp:~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi into lp:account-financial-report.

=== modified file 'account_financial_report_webkit/account_move_line.py'
--- account_financial_report_webkit/account_move_line.py	2012-12-11 16:32:26 +0000
+++ account_financial_report_webkit/account_move_line.py	2014-04-25 13:34:20 +0000
@@ -28,24 +28,6 @@
     Last rec date is the date of the last reconciliation (full or partial) account move line"""
     _inherit = 'account.move.line'
 
-    def init(self, cr):
-        ##We do not want to catch error as if sql is not run it will give invalid data
-        cr.execute("UPDATE account_move_line as acm "
-                   " SET last_rec_date ="
-                   "     (SELECT date from account_move_line"
-                   "          WHERE reconcile_id =  acm.reconcile_id"
-                   "              AND reconcile_id IS NOT NULL"
-                   "          ORDER BY date DESC LIMIT 1)"
-                   " WHERE last_rec_date is null;")
-
-        cr.execute("UPDATE account_move_line as acm "
-                   " SET last_rec_date ="
-                   "     (SELECT date from account_move_line"
-                   "          WHERE reconcile_partial_id =  acm.reconcile_partial_id"
-                   "              AND reconcile_partial_id IS NOT NULL"
-                   "          ORDER BY date DESC LIMIT 1)"
-                   " WHERE last_rec_date is null;")
-
     def _get_move_line_from_line_rec(self, cr, uid, ids, context=None):
         moves = []
         for reconcile in self.pool.get('account.move.reconcile').browse(cr, uid, ids, context=context):

=== added directory 'account_financial_report_webkit/migrations'
=== added directory 'account_financial_report_webkit/migrations/7.0.1.0.2'
=== added file 'account_financial_report_webkit/migrations/7.0.1.0.2/post-migration.py'
--- account_financial_report_webkit/migrations/7.0.1.0.2/post-migration.py	1970-01-01 00:00:00 +0000
+++ account_financial_report_webkit/migrations/7.0.1.0.2/post-migration.py	2014-04-25 13:34:20 +0000
@@ -0,0 +1,39 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    Author: Nicolas Bessi.
+#    Copyright Camptocamp SA 2011
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU General Public License as published by
+#    the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU General Public License for more details.
+#
+#    You should have received a copy of the GNU General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+def migrate(cr, version):
+    if not version:
+        # only run at first install
+        cr.execute("UPDATE account_move_line as acm "
+                   " SET last_rec_date ="
+                   "     (SELECT date from account_move_line"
+                   "          WHERE reconcile_id =  acm.reconcile_id"
+                   "              AND reconcile_id IS NOT NULL"
+                   "          ORDER BY date DESC LIMIT 1)"
+                   " WHERE last_rec_date is null;")
+    
+        cr.execute("UPDATE account_move_line as acm "
+                   " SET last_rec_date ="
+                   "     (SELECT date from account_move_line"
+                   "          WHERE reconcile_partial_id =  acm.reconcile_partial_id"
+                   "              AND reconcile_partial_id IS NOT NULL"
+                   "          ORDER BY date DESC LIMIT 1)"
+                   " WHERE last_rec_date is null;")