openerp-community-reviewer team mailing list archive

[Chang Phui-Hock <phuihock@xxxxxxxxxxxx>]

Hi Daniel,
Thanks for taking the time to review this MP.

I like your idea. It does sound like more flexible for future
customization. In fact, I studied the standard hr_timesheet module before
deciding to write this one, partly because we did not have the time budget
at that moment.

If this module is to be done "properly", it will then involve not so
trivial changes. Is it not advisable to get this module merged, and start a
new module which then deprecates this one?


*Chang Phui Hock*
CODEKAKI SYSTEMS (R49045/14) - A web-dev company
Address: TB 15588-1 1st Floor, Lrg Kubota, Kubota Square, 91000 Tawau.
Tel: +6018-263 9102
Skype: phuihock
Website: http://www.codekaki.com


On Sun, Apr 27, 2014 at 1:23 AM, Daniel Reis <dgreis@xxxxxxx> wrote:

> First of all thanks for embracing the open-source spirit by sharing your
> module!
>
> The current features are of course focused on your specific use case.
> But it would be good for your module to be the foundation to build on for
> more complex usa cases.
>
> For that, I would suggest a slightly different design, following the
> implementation strategy used in standard hr_timesheet, but where:
> * each cell is actually a record, for a Date + Shift Code (instead of a
> column of a row).
> * each line is an Employee (instead of an Analytic Account)
> * the header is a Position / Location to be rostered (instead of an
> employee).
>
> I can exemplify two possible extensions having this structure:
> a) have richer information on each Cell, such as comments, specific
> duties, flags for overtime or night work, etc.
> b) support other planning periods, such as rolling 4 week periods instead
> of full.
> to the Timesheet module:would be a one month view over a "Position Roster":
>
> --
> https://code.launchpad.net/~codekaki/openerp-hr/7.0-hr_roster/+merge/217116
> You proposed lp:~codekaki/openerp-hr/7.0-hr_roster for merging.
>

-- 
https://code.launchpad.net/~codekaki/openerp-hr/7.0-hr_roster/+merge/217116
Your team HR Core Editors is requested to review the proposed merge of lp:~codekaki/openerp-hr/7.0-hr_roster into lp:openerp-hr.