openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-1275659-crm-my-items-filters into lp:ocb-addons/6.1

To: Yann Papouin <yann.papouin@xxxxxxxxx>
From: "Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>
Date: Mon, 28 Apr 2014 12:53:06 -0000
In-reply-to: <20140203141031.2602.91262.launchpad@ackee.canonical.com>
Reply-to: mp+204498@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Disapprove

Not against this change per se, but I'm thinking that users are going to be annoyed if these untranslated buttons show up. So in this particular case I think having the improvement in a separate module in which the translations can be maintained easily should be preferred.

-- 
https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1275659-crm-my-items-filters/+merge/204498
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons/6.1.

References

[Merge] lp:~yann-papouin/ocb-addons/6.1-bug-1275659-crm-my-items-filters into lp:ocb-addons/6.1
From: Yann Papouin, 2014-02-03