openerp-community-reviewer team mailing list archive

["Sandy Carter \(http://www.savoirfairelinux.com\)" <sandy.carter@xxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing

except_osv is depricated, please use except_orm
l.213 missing context propagation
l.276 POSSIBLE SQL INJECTION with filenames which contain quotes, please use appropriate code escapes from the library (don't write your own)
No Unittests

Flake8:
cmis/cmis_model.py:25:1: F401 'job' imported but unused
cmis/cmis_model.py:27:1: F401 'connector' imported but unused
cmis/cmis_model.py:28:1: F401 'ConnectorSession' imported but unused
cmis/cmis_model.py:29:1: F401 'base64' imported but unused
cmis/cmis_model.py:71:9: E265 block comment should start with '# '
cmis/cmis_model.py:84:13: F841 local variable 'someDoc' is assigned to but never used
cmis/cmis_model.py:92:9: F841 local variable 'ir_attach_dms_obj' is assigned to but never used
cmis/cmis_model.py:96:9: E265 block comment should start with '# '
cmis/cmis_model.py:97:9: E265 block comment should start with '# '
cmis/cmis_model.py:120:17: F841 local variable 'res' is assigned to but never used
cmis/connector.py:23:1: F401 'fields' imported but unused
cmis/connector.py:23:1: F401 'orm' imported but unused
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis/+merge/212258
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:knowledge-addons/7.0.