openerp-community-reviewer team mailing list archive
-
openerp-community-reviewer team
-
Mailing list archive
-
Message #06553
Re: [Merge] lp:~akretion-team/sale-wkfl/7.0-add-sale_group into lp:sale-wkfl
Review: Needs Fixing
Raphaël,
__openerp__.py:
- The description could be expanded a bit, maybe mentioning the reverse dependency on sale_import_lines.
- Description: "groups that belongs". That sentence could be rewritten, in fact :)
- we don't need init_xml, demo_xml.
- category is empty.
Apart from these small things, if eveything passes pep8 (can you check please? ) it LGTM, thanks.
--
https://code.launchpad.net/~akretion-team/sale-wkfl/7.0-add-sale_group/+merge/201017
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
References