openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis_write into lp:knowledge-addons/7.0

To: "El Hadji Dem \(http://www.savoirfairelinux.com\)" <elhadji.dem@xxxxxxxxxxxxxxxxxxxx>
From: "Sandy Carter \(http://www.savoirfairelinux.com\)" <sandy.carter@xxxxxxxxxxxxxxxxxxxx>
Date: Tue, 06 May 2014 14:17:52 -0000
In-reply-to: <20140402222321.6821.79534.launchpad@ackee.canonical.com>
Reply-to: mp+213940@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

l.416 Missing context propagation

Spelling:
You wrote OpenErp a few times. This should be OpenERP.
The description is oddly formulated, you may want it proofread.

Flake8:
cmis_write/__openerp__.py:58:26: W291 trailing whitespace
cmis_write/ir_attachment.py:125:5: E265 block comment should start with '# '
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_write/+merge/213940
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:knowledge-addons/7.0.

References

[Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis_write into lp:knowledge-addons/7.0
From: El Hadji Dem (http://www.savoirfairelinux.com), 2014-04-02