openerp-community-reviewer team mailing list archive
-
openerp-community-reviewer team
-
Mailing list archive
-
Message #06594
Re: [Merge] lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde into lp:stock-logistic-flows
Review: Needs Fixing code review, no test
Shouldn't *_to_done private method be *_to_do or _to_be_done ?
Here are few remarks about translations:
* After installatation on fresh install with last code Wizard fields and label aren't translated. (But this may not be related to this MP)
* In translation, in french there should be a space before punctuation.
* "selon le nombre de commandes de vente voulu." I would replace 'voulu' by 'défini'.
* l.291 +msgstr "Prépare un bon de préparation" -> Préparer
* picker_id help message is not translated nor picking_id field name
--
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde/+merge/214568
Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows.
References