← Back to team overview

openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055 into lp:department-mgmt

To: mp+212286@xxxxxxxxxxxxxxxxxx
From: Joël Grand-Guillaume @ camptocamp <joel.grandguillaume@xxxxxxxxxxxxxx>
Date: Thu, 08 May 2014 13:03:22 -0000
In-reply-to: <20140322141222.11498.85633.launchpad@ackee.canonical.com>
Reply-to: mp+212286@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review, no tests

Hi,

Sorry I miss something :

Line 24 and 55, if employee has no department_id define, the code will break.

Can you please add a test on department_id.

Regards,
-- 
https://code.launchpad.net/~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055/+merge/212286
Your team Department Core Editors is subscribed to branch lp:department-mgmt.

References

[Merge] lp:~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055 into lp:department-mgmt
From: JB (eficent.com), 2014-03-22