openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~savoirfairelinux-openerp/account-invoicing/account_invoice_line_merge into lp:account-invoicing

To: "Maxime Chambreuil \(http://www.savoirfairelinux.com\)" <maxime.chambreuil@xxxxxxxxxxxxxxxxxxxx>
From: Joël Grand-Guillaume @ camptocamp <joel.grandguillaume@xxxxxxxxxxxxxx>
Date: Fri, 09 May 2014 12:00:17 -0000
In-reply-to: <20140417135530.9406.57396.launchpad@ackee.canonical.com>
Reply-to: mp+216327@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review, no tests

Hi,


Thanks for the contrib. It seems to me that you have a strange diff here, like if files or folder have been here more than once ? Can you check and clean the MP ?

Otherwise, the code is looking good to me.

Regards,

Joël
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/account-invoicing/account_invoice_line_merge/+merge/216327
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

References

[Merge] lp:~savoirfairelinux-openerp/account-invoicing/account_invoice_line_merge into lp:account-invoicing
From: Maxime Chambreuil (http://www.savoirfairelinux.com), 2014-04-17