openerp-community-reviewer team mailing list archive

[Joël Grand-Guillaume @ camptocamp <joel.grandguillaume@xxxxxxxxxxxxxx>]

Review: Needs Fixing code review, no tests

Hi David,


Thanks for porting this module. A few remarks:

 * Would you please consider using the BZR extractor (https://launchpad.net/bazaar-extractor) to put this module in that branch ? This will then keep the commite message insead of having just one commit that add the module. This seems fair on order to keep the author's work.

 * Then, it deserve a bit of PEP8 formatting

Regards,


Joël
-- 
https://code.launchpad.net/~david-cormier-j/sale-wkfl/sale_landed_costs/+merge/205650
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.