← Back to team overview

openerp-community-reviewer team mailing list archive

Re: [Merge] lp:~camptocamp/department-mgmt/add-account-department-fix-default-anyltic-jge into lp:department-mgmt

 

Review: Needs Fixing

l.21: context propagation is missing
l.25-25: indentation could be aligned
l.37: if the department of the account changes, the analytic lines won't be changed. That's maybe what is wanted though. I propose either to add triggers, either to add a comment why the departement on the analytic lines should not be changed
-- 
https://code.launchpad.net/~camptocamp/department-mgmt/add-account-department-fix-default-anyltic-jge/+merge/218807
Your team Department Core Editors is subscribed to branch lp:department-mgmt.


References