openerp-community-reviewer team mailing list archive

[Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>]

Review: Needs Fixing code review

Hi, Lorenzo,

Please use correct indentation in if sentence for PEP8 compliance (higher than nested block).

Functionally speaking, it seems good, but maybe you can do:

if (float_end_time - float_start_time) < 0.0000001:

and simplify the condition.

Regards.
-- 
https://code.launchpad.net/~agilebg/hr-timesheet/imp_hr_attendance_analysis_roundings/+merge/206493
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:hr-timesheet.