openerp-community-reviewer team mailing list archive

[Daniel Reis <dgreis@xxxxxxx>]

Review: Approve

I believe this covers the distinct user cases better than Jordi's MP.
So I would prefer for this one to be merged.
Anyway, I invited him for this review.


On the syle side, it's just a personal preference, but for:

    employee_ids = employee_obj.search(cr, uid,
                                       [('user_id','=', uid)],
                                       context=context)

I usually prefer:

    employee_ids = employee_obj.search(
        cr, uid,[('user_id','=', uid)], context=context)


-- 
https://code.launchpad.net/~camptocamp/department-mgmt/add-account-department-fix-default-anyltic-jge/+merge/218807
Your team Department Core Editors is subscribed to branch lp:department-mgmt.