openerp-community-reviewer team mailing list archive

["Yannick Vaucher @ Camptocamp" <yannick.vaucher@xxxxxxxxxxxxxx>]

The proposal to merge lp:~camptocamp/ocb-addons/7.0-fix-1319095 into lp:ocb-addons has been updated.

Description changed to:

Use NamedTemporaryFile instead of file and of deprecated mktemp. That way we ensure 2 files created at the exact same time will have a unique name


Another hot fix from Florent was made here https://code.launchpad.net/~florent.x/openobject-addons/trunk-1290820-report_webkit/+merge/210387

I believe this one is a bit cleaner as it refactor a bit the code. However it doesn't keep timestamp in file name. But do we need timestamp in file name ?

If so I can still add it in prefix or suffix.

For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1319095/+merge/219476
-- 
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1319095/+merge/219476
Your team OpenERP Community Backports is requested to review the proposed merge of lp:~camptocamp/ocb-addons/7.0-fix-1319095 into lp:ocb-addons.