openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1319095 into lp:ocb-addons

To: mp+219476@xxxxxxxxxxxxxxxxxx
From: Alexandre Fayolle - camptocamp <alexandre.fayolle@xxxxxxxxxxxxxx>
Date: Wed, 14 May 2014 09:37:23 -0000
In-reply-to: <20140514085952.8349.68983.launchpad@ackee.canonical.com>
Reply-to: mp+219476@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review, no test

This fix will not work on Windows. 

out_filename is opened on line 11 of the file, and then the pdf converter will try to open a file with the same name while the file is still open in OpenERP which will fail on windows (https://docs.python.org/2.7/library/tempfile.html?highlight=namedtemporaryfile#tempfile.NamedTemporaryFile)


-- 
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1319095/+merge/219476
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.

References

[Merge] lp:~camptocamp/ocb-addons/7.0-fix-1319095 into lp:ocb-addons
From: Yannick Vaucher @ Camptocamp, 2014-05-14