← Back to team overview

openerp-community-reviewer team mailing list archive

Re: [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis into lp:knowledge-addons/7.0

 

Review: Needs Information

l.225,259 can you please explain what you do here. It seems you attempt to write to a directory to test if you have write permission, surely there are safer ways of doing this.

In you unittest, can you test more of your functions, I know there is a challenge of not having a cmis server running to the tests, but even testing for a raised exception is better than just testing the model.
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis/+merge/212258
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:knowledge-addons/7.0.


References