openerp-community-reviewer team mailing list archive

[Lionel Sausin - Numérigraphe <ls@xxxxxxxxxxxxxxxx>]

Review: Needs Fixing formal nitpicking

First off, some formal comments:
- in.txt and out.pdf should probably be left out
- README is empty, either remove it or write something in it please
- please add a copyright note at the top of your files, I think they're useful to avoid ambiguity
- in __openerp__.py:
    - please add a description
    - you may remove the fields init_xml, demo_xml, test, auto_install, complexity and installable
    - there's a space at the end of the "name" field
- it would be nice to get closer to PEP8 (no spaces before ':', 80 cols, empty lines...)
I'll examine and test the module further.
-- 
https://code.launchpad.net/~bruno-bottacini/report-print-send/7.0-report_webkit_custom_paper_size/+merge/202892
Your team Report Printing and Sending Core Editors is requested to review the proposed merge of lp:~bruno-bottacini/report-print-send/7.0-report_webkit_custom_paper_size into lp:report-print-send.