openerp-community-reviewer team mailing list archive

[Lionel Sausin - Numérigraphe <ls@xxxxxxxxxxxxxxxx>]

Lionel Sausin - Numérigraphe has proposed merging lp:~numerigraphe-team/report-print-send/7.0-improve-prefs-ui-ls into lp:report-print-send.

Requested reviews:
  Report Printing and Sending Core Editors (report-print-send-core-editors)

For more details, see:
https://code.launchpad.net/~numerigraphe-team/report-print-send/7.0-improve-prefs-ui-ls/+merge/219787

Improve the preference views of base_report_to_printer:
Menus:
- move the printing settings to a menu of their own in the "settings" page (ie. move one level up)
- add a shortcut to the list of reports to the printing menu
Printing preferences:
- fix the preference view (the group was inserted inside another group, now it's cleanly inserted at the end)
- add the printing preferences to the user prefs ("preferences" in the menu on the far upper-right corner)

-- 
https://code.launchpad.net/~numerigraphe-team/report-print-send/7.0-improve-prefs-ui-ls/+merge/219787
Your team Report Printing and Sending Core Editors is requested to review the proposed merge of lp:~numerigraphe-team/report-print-send/7.0-improve-prefs-ui-ls into lp:report-print-send.

=== modified file 'base_report_to_printer/printing_view.xml'
--- base_report_to_printer/printing_view.xml	2013-10-01 13:04:19 +0000
+++ base_report_to_printer/printing_view.xml	2014-05-16 07:25:13 +0000
@@ -2,7 +2,7 @@
 <openerp>
   <data>
 
-    <menuitem name="Printing" id="menu_printing_main" parent="base.menu_config" groups="res_groups_printingprintoperator0"/>
+    <menuitem name="Printing" id="menu_printing_main" parent="base.menu_administration" groups="res_groups_printingprintoperator0"/>
 
     <record model="ir.ui.view" id="view_printing_printer_form">
       <field name="name">printing.printer.form</field>
@@ -76,12 +76,27 @@
       <field name="model">res.users</field>
       <field name="inherit_id" ref="base.view_users_form" />
       <field name="arch" type="xml">
-        <field name="lang" position="after">
-          <group>
-            <field name="printing_action"/>
-            <field name="printing_printer_id"/>
-          </group>
-        </field>
+        <page string="Preferences">
+          <group name="printing">
+            <field name="printing_action"/>
+            <field name="printing_printer_id"/>
+          </group>
+        </page>
+      </field>
+    </record>
+
+    <!-- "My Preferences -->
+    <record model="ir.ui.view" id="view_printing_users_prefs">
+      <field name="name">res.users.form.printing</field>
+      <field name="model">res.users</field>
+      <field name="inherit_id" ref="base.view_users_form_simple_modif" />
+      <field name="arch" type="xml">
+        <footer position="before">
+          <group string="Printing" name="printing">
+            <field name="printing_action"/>
+            <field name="printing_printer_id"/>
+          </group>
+        </footer>
       </field>
     </record>
 
@@ -91,10 +106,11 @@
       <field name="model">printing.report.xml.action</field>
       <field name="arch" type="xml">
         <form string="Report Printing Actions">
-          <field name="user_id"/>
-          <label string=""/>
-          <field name="action"/>
-          <field name="printer_id" select="1"/>
+          <group col="2">
+              <field name="user_id"/>
+              <field name="action"/>
+              <field name="printer_id" select="1"/>
+          </group>
         </form>
       </field>
     </record>
@@ -110,5 +126,9 @@
       </field>
     </record>
 
+    <!-- Add a shorcut to "Actions/Report" in the Printing menu -->
+    <menuitem id="menu_printing_reports"
+      parent="menu_printing_main"
+      action="base.ir_action_report_xml"/>
   </data>
 </openerp>