openerp-community-reviewer team mailing list archive
-
openerp-community-reviewer team
-
Mailing list archive
-
Message #06796
Re: [Merge] lp:~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde into lp:openerp-rma
Review: Needs Fixing nitpicking
Looks good from code point of view, not tested because I don't use this module.
Now for the nitpicking:
- multiline docstrings should have the short description on the first line, and the details in the following lines. This lets IDEs show the first line as a quick help.
- please don't initialize the context if you don't use it - it's ok to pass None to other methods.
--
https://code.launchpad.net/~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde/+merge/218666
Your team OpenERP RMA is subscribed to branch lp:openerp-rma.
References