openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~agilebg/purchase-wkfl/imp_product_by_supplier into lp:purchase-wkfl

To: Lorenzo Battistini - Agile BG <lorenzo.battistini@xxxxxxxxxxx>
From: Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>
Date: Tue, 20 May 2014 00:52:41 -0000
In-reply-to: <20140509162121.13900.69904.launchpad@ackee.canonical.com>
Reply-to: mp+219017@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information code review

Hi, Lorenzo, thanks for expanding this module.

I see a possible problem giving more priority to partner search than to any other, because you make a return in case that there are ids in this search. I think you must join all results to allow for example "Search more..." option to appear.

Regards.
-- 
https://code.launchpad.net/~agilebg/purchase-wkfl/imp_product_by_supplier/+merge/219017
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.

References

[Merge] lp:~agilebg/purchase-wkfl/imp_product_by_supplier into lp:purchase-wkfl
From: Lorenzo Battistini - Agile BG, 2014-05-09