openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~akretion-team/server-env-tools/module-configuration-helper-dbl into lp:server-env-tools

To: David BEAL <david.beal@xxxxxxxxxxxx>
From: "Yannick Vaucher @ Camptocamp" <yannick.vaucher@xxxxxxxxxxxxxx>
Date: Wed, 21 May 2014 09:32:28 -0000
In-reply-to: <20140521084119.22291.19416.launchpad@ackee.canonical.com>
Reply-to: mp+220392@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing test + code review

Used it to create a config and works well.


Code review

l.161 + l.163 + l.172 please remove commented print line

l.226 no need to quote me for this code I took it from 
addons/account/res_config.py
-- 
https://code.launchpad.net/~akretion-team/server-env-tools/module-configuration-helper-dbl/+merge/220392
Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools.

References

[Merge] lp:~akretion-team/server-env-tools/module-configuration-helper-dbl into lp:server-env-tools
From: David BEAL, 2014-05-21