openerp-community-reviewer team mailing list archive

[Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>]

Review: Needs Fixing code review

Thanks for the changes. I'm thinking that if the method is intended for customizing sender address, you should return a dictionary that it's written on base module, because in this way, you have to do it your way in your custom module and inheritance is not possible in this way.

You can see one of this type of hooks in prepare_inv_line of sale module.

Regards.
-- 
https://code.launchpad.net/~akretion-team/carriers-deliveries/7-base-delivery-carrier-dbl/+merge/221226
Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries.