openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix2 into lp:account-financial-report

To: mp+216380@xxxxxxxxxxxxxxxxxx
From: Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>
Date: Sat, 07 Jun 2014 10:16:10 -0000
In-reply-to: <20140417183120.6704.1927.launchpad@ackee.canonical.com>
Reply-to: mp+216380@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information code review

Hi, Luc,

I see your solution very restricted, because you can have an special period for each fiscal year. Setting it at company level doesn't seem the best approach. Why don't you put it at fiscal year level?

Regards.
-- 
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix2/+merge/216380
Your team Account Report Core Editors is subscribed to branch lp:account-financial-report.

Follow ups

Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix2 into lp:account-financial-report
From: Luc De Meyer (Noviat), 2014-06-07

References

[Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix2 into lp:account-financial-report
From: Luc De Meyer (Noviat), 2014-04-17