openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~hirt/ocb-addons/6.1_stock-move-tree into lp:ocb-addons/6.1

To: mp+222463@xxxxxxxxxxxxxxxxxx
From: Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>
Date: Mon, 09 Jun 2014 07:27:19 -0000
In-reply-to: <20140608215721.14023.92443.launchpad@ackee.canonical.com>
Reply-to: mp+222463@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review

The change on priority LGTM, but there are two things that you have to fix:

- You cannot remove a view from an stable version, because maybe someone has constructed an inherited view around it in his custom module. Please keep it, although it is a leftover view.
- Change executable flags on a separate MP.

Regards.
-- 
https://code.launchpad.net/~hirt/ocb-addons/6.1_stock-move-tree/+merge/222463
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1.

References

[Merge] lp:~hirt/ocb-addons/6.1_stock-move-tree into lp:ocb-addons/6.1
From: Etienne Hirt, 2014-06-08