openerp-community-reviewer team mailing list archive
-
openerp-community-reviewer team
-
Mailing list archive
-
Message #07142
Re: [Merge] lp:~camptocamp/account-financial-tools/add-manual-line-and-fees-nbi into lp:account-financial-tools
Review: Needs Fixing code review
Hello,
Just little things as:
- I see deprecated attribute type on form views (l.869, 906)
- l.2221: s/Euro policy level/Usd policy level
- l.1310, 1311: '==' instead of '='
Otherwise, few little typos:
- l.1709: s/writen/written
- l.1709: s/fields/field
- l.2199: s/Initialaize/Initialize
- I would add commas on l.280, 290, 1392
- I would remove double spaces on l.699, 725
thanks for these new features,
Romain
--
https://code.launchpad.net/~camptocamp/account-financial-tools/add-manual-line-and-fees-nbi/+merge/218584
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools.
References