← Back to team overview

openerp-community-reviewer team mailing list archive

Re: [Merge] lp:~camptocamp/sale-reports/vre-sale_order_proformat into lp:sale-reports

 

Review: Needs Fixing code review and test

Thanks for the changes, Vincent. Now it works as intended. Only one last fix: please put at the end of the mako file this:

%if inv != objects[-1]:
    <p style="page-break-after:always"/>
%endif

That is because depending on the wkhtmltopdf version, you get an extra blank page at the end. With this, you always get the same result.

Regards.
-- 
https://code.launchpad.net/~camptocamp/sale-reports/vre-sale_order_proformat/+merge/223563
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:sale-reports.


References