openerp-community-reviewer team mailing list archive

[Romain Deheele - Camptocamp <romain.deheele@xxxxxxxxxxxxxx>]

Review: Needs Fixing code review

Hi Vincent,

I'm not sure but I think it's better to put ## -*- coding: utf-8 -*- at the start of mako file.

other small things:
l.10,36 : comma is misplaced between our 2 names
l.62 : s/base_header_webkit/base_headers_webkit

Thanks for porting this addon here,

Romain


-- 
https://code.launchpad.net/~camptocamp/sale-reports/vre-sale_order_proformat/+merge/223563
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:sale-reports.