openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~camptocamp/stock-logistic-barcode/7.0-fix_1330459-sge+afe into lp:stock-logistic-barcode

To: Alexandre Fayolle - camptocamp <alexandre.fayolle@xxxxxxxxxxxxxx>
From: "Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>
Date: Fri, 20 Jun 2014 07:47:53 -0000
In-reply-to: <20140620074052.9600.95045.launchpad@ackee.canonical.com>
Reply-to: mp+223866@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code review

When you want to rename a field, you can also use the 'oldname' argument, example in crm:

        'opt_out': fields.boolean('Opt-Out', oldname='optout',
            help="If opt-out is checked, this contact has refused to receive emails for mass mailing and marketing campaign. "
                    "Filter 'Available for Mass Mailing' allows users to filter the leads when performing mass mailing."),

The ORM would automatically rename the field.

Your version is also a valid way to rename the field so LGTM.
-- 
https://code.launchpad.net/~camptocamp/stock-logistic-barcode/7.0-fix_1330459-sge+afe/+merge/223866
Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-barcode.