openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~akretion-team/carriers-deliveries/7-split-default-option-state-from-deliv-method-dbl into lp:carriers-deliveries

To: "David BEAL \(ak\)" <david.beal@xxxxxxxxxxxx>
From: Sébastien BEAU - http://www.akretion.com <sebastien.beau@xxxxxxxxxxxx>
Date: Mon, 23 Jun 2014 07:14:36 -0000
In-reply-to: <20140621171622.14137.1896.launchpad@ackee.canonical.com>
Reply-to: mp+224027@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Hi
You don't have to test "if available_option.mandatory is True" but you can only use "if available_option.mandatory" as it's a boolean the "is True" is useless.
-- 
https://code.launchpad.net/~akretion-team/carriers-deliveries/7-split-default-option-state-from-deliv-method-dbl/+merge/224027
Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries.

References

[Merge] lp:~akretion-team/carriers-deliveries/7-split-default-option-state-from-deliv-method-dbl into lp:carriers-deliveries
From: David BEAL (ak), 2014-06-21