openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~akretion-team/account-closing/70-forecast-prepaid into lp:account-closing

To: Alexis de Lattre <alexis@xxxxxxxxxx>
From: Alexandre Fayolle - camptocamp <alexandre.fayolle@xxxxxxxxxxxxxx>
Date: Thu, 26 Jun 2014 12:31:31 -0000
In-reply-to: <20140309002121.25280.61908.launchpad@ackee.canonical.com>
Reply-to: mp+210066@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review, no tests

please add automated tests. 

Additionally I'm interested in an explanation about the various comparison operators used : sometimes you use strict inequality, sometime -or-equal comparison (e.g. line 241 vs line 248). 



-- 
https://code.launchpad.net/~akretion-team/account-closing/70-forecast-prepaid/+merge/210066
Your team Account Core Editors is subscribed to branch lp:account-closing.

References

[Merge] lp:~akretion-team/account-closing/70-forecast-prepaid into lp:account-closing
From: Alexis de Lattre, 2014-03-09