openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-add-account_trial_balance_period_xls into lp:account-financial-report

To: mp+224024@xxxxxxxxxxxxxxxxxx
From: Alexandre Fayolle - camptocamp <alexandre.fayolle@xxxxxxxxxxxxxx>
Date: Thu, 26 Jun 2014 14:29:12 -0000
In-reply-to: <20140621155321.24404.56763.launchpad@ackee.canonical.com>
Reply-to: mp+224024@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review, no tests

1. please run flake8 on the code and fix the issues. There are lots of long lines, missing/superfluous spaces, as well as unused imports. 

2. please add an automated test which will generate a report and ensure at least some coverage of the module. 


-- 
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-add-account_trial_balance_period_xls/+merge/224024
Your team Account Report Core Editors is subscribed to branch lp:account-financial-report.

References

[Merge] lp:~luc-demeyer/account-financial-report/7.0-add-account_trial_balance_period_xls into lp:account-financial-report
From: Luc De Meyer (Noviat), 2014-06-21