← Back to team overview

openerp-community-reviewer team mailing list archive

Re: [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1335887 into lp:ocb-addons

 

Review: Disapprove

Personally I think this merge proposal is tackling the problem from the wrong end.

If we do not have an origin for a purchase order, the value for origin should be NULL, not an empty string.

The original code that introduced the bug should be amended to account for the possibility of NULL values in the database.
-- 
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1335887/+merge/225028
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.