openerp-community-reviewer team mailing list archive

[Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>]

Review: Needs Fixing code review

Little comment inline.

Regards.

Diff comments:

> === modified file 'purchase/purchase.py'
> --- purchase/purchase.py	2014-04-15 08:12:11 +0000
> +++ purchase/purchase.py	2014-06-30 16:02:52 +0000
> @@ -793,8 +793,11 @@
>                  if porder.notes:
>                      order_infos['notes'] = (order_infos['notes'] or '') + ('\n%s' % (porder.notes,))
>                  if porder.origin:
> -                    if not porder.origin in order_infos['origin'] and not order_infos['origin'] in porder.origin:
> -                        order_infos['origin'] = (order_infos['origin'] or '') + ' ' + porder.origin
> +                    if not order_infos['origin']:
> +                        order_infos['origin'] = porder.origin
> +                    elif (not porder.origin in order_infos['origin']
> +                            and not order_infos['origin'] in porder.origin):
> +                        order_infos['origin'] = order_infos['origin'] + ' ' + porder.origin

Better to compact it: order_infos['origin'] += ' ' + porder.origin

>  
>              for order_line in porder.order_line:
>                  line_key = make_key(order_line, ('name', 'date_planned', 'taxes_id', 'price_unit', 'product_id', 'move_dest_id', 'account_analytic_id'))
> 


-- 
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1335887/+merge/225028
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.