openerp-community-reviewer team mailing list archive

[Leonardo Pistone - camptocamp <leonardo.pistone@xxxxxxxxxxxxxx>]

Review: Needs Fixing

Hi.

l27: where you do '\n'.join I would feel more confortable having u'\n'.join because char fields are unicode, at least with translated fields (by the way, "at least" is a bad inconsistency in the framework).

l32: context={} -> context=None

self.pool.get -> self.pool[]

thanks
-- 
https://code.launchpad.net/~agilebg/purchase-wkfl/imp_product_by_supplier/+merge/225197
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.