openerp-community-reviewer team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Ouch, you are right. While the file size is passed to _check_duplication, it is ignored further down and any file on the same resource with the same name is considered a dupe. The same thing happens on write(), in which case the data is being overwritten. This could be a 'feature' that other parts of the code depend on, and changing this behaviour could lead to an unexpected explosion of documents with the same name. I need to think about a possible solution to this.

-- 
https://code.launchpad.net/~therp-nl/ocb-addons/6.1-lp1342360-fetchmail_file_storage_duplicate_attachment_ids/+merge/226933
Your team OpenERP Community Backports is requested to review the proposed merge of lp:~therp-nl/ocb-addons/6.1-lp1342360-fetchmail_file_storage_duplicate_attachment_ids into lp:ocb-addons/6.1.