openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~therp-nl/partner-contact-management/7.0-firstname_display_name_trigger_prepare_name into lp:partner-contact-management

To: "Holger Brunn \(Therp\)" <hbrunn@xxxxxxxx>
From: Leonardo Pistone - camptocamp <leonardo.pistone@xxxxxxxxxxxxxx>
Date: Thu, 17 Jul 2014 09:15:04 -0000
In-reply-to: <20140717083121.5350.86640.launchpad@ackee.canonical.com>
Reply-to: mp+227152@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Apparently a symlink is gone in that commit.

The diff also says "=== target was u'base_location'" which I don't understand.

If that is intentional, can you please split into another commit and elaborate in the commit message?

Thanks!
-- 
https://code.launchpad.net/~therp-nl/partner-contact-management/7.0-firstname_display_name_trigger_prepare_name/+merge/227152
Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management.

References

[Merge] lp:~therp-nl/partner-contact-management/7.0-firstname_display_name_trigger_prepare_name into lp:partner-contact-management
From: Holger Brunn (Therp), 2014-07-17