openerp-community-reviewer team mailing list archive

["Ronald Portier \(Therp\)" <ronald@xxxxxxxx>]

Review: Needs Fixing

In the if with the check_duplication, maybe first test the values, because the method call to check_duplication makes no sense if they are not filled.

Do I understand correctly that a create is turned into a write if records are found that are not duplicate according to the check, but that share the same resource and datas_fname?
-- 
https://code.launchpad.net/~hbrunn/ocb-addons/6.1-knowledge_attachment_create_fix_duplicate_check/+merge/285359
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1.