← Back to team overview

openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~hbrunn/ocb-addons/6.1-knowledge_attachment_create_fix_duplicate_check into lp:ocb-addons/6.1

To: "Holger Brunn \(Therp\)" <hbrunn@xxxxxxxx>
From: "Ronald Portier \(Therp\)" <ronald@xxxxxxxx>
Date: Wed, 10 Feb 2016 14:42:32 -0000
In-reply-to: <20160208151723.18073.16516.launchpad@ackee.canonical.com>
Reply-to: mp+285359@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

I was just thinking of saving a method call, I have seen that check_duplication does not break on missing values. (But is will do a nonsensical search).

Not blocking for me.
-- 
https://code.launchpad.net/~hbrunn/ocb-addons/6.1-knowledge_attachment_create_fix_duplicate_check/+merge/285359
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1.

References

[Merge] lp:~hbrunn/ocb-addons/6.1-knowledge_attachment_create_fix_duplicate_check into lp:ocb-addons/6.1
From: Holger Brunn (Therp), 2016-02-08