openerp-community team mailing list archive

["Olivier Dony \(OpenERP\)" <odo@xxxxxxxxxxx>]

Review: Needs Fixing
Hello Eric,

Sorry about the delay, merge proposal reviews might take a few days or weeks depending on the workload of the R&D teams, but we are trying to improve it. Members of the community are also free to provide useful feedback on each other's patches.

Concerning this merge proposal, it is difficult to understand what you want to achieve...
I think you had a technical issue when creating the branch and pushing it on launchpad, so you might want to work on it, starting with the following issues:

- The description of your merge proposal is quite small, and does not seem to match the content of your branch at all.

- Look at the diff of the merge proposal or the content of the proposed branch: you'll see that it contains 2 empty modules. Your branch also appears to be stacked on the trunk addons branch, but this is not the case, as its revision numbers start at 1. I think you need to push your changes against, more carefully. If you are proposing a change of the official addons branch, your branch should be based on the lp:~openerp/openobject-addons/trunk branch, with a few revisions on top of the last official changes, to introduce your changes. If you are adding a module, there should be a revision that adds a new module directory next to the other official ones.

- The naming of you branch seems to imply it is meant for OpenERP v6.0, but it is proposed against the trunk branch. Proposing against 6.0 would be a waste of time indeed because it is stable now so no new features will be added in any case. Proposing against trunk makes sense if you think your changes are relevant for being included in the official addons for next version, but this is still unclear at this point ;-)


Now, a more generic comment: it is not very often that new modules are added to the official addons, as we try to keep the core lean and simple. Modules that customize core modules should usually be published as extra-addons (to be referenced on apps.openerp.com), and will only be included in the official addons once it's shown that they are clean and relevant for most OpenERP users.
You can publish such modules in your own LP branch (and then register it on apps.openerp.com), or add them to the community-addons (lp:~openerp-community/openobject-addons/trunk-addons-community) or extra-addons (lp:openobject-addons/extra-trunk or lp:openobject-addons/extra-6.0).
You should also try to have the simplest and most relevant name possible for your modules in any case (the author of a module is part of the metadata, no need to put it in the module name)

On the other hand, if your module is patching core features of OpenERP and is meant as an improvement of these features, then you might be better off modifying the core modules in your merge proposal than trying to add new modules.

Finally, you should keep in mind that the chances of seeing a merge proposal accepted decrease with the number of lines and complexity of the changes, so think about it (splitting the changes in small  per-topic branches might be an option)

I hope this helps... 

Do not hesitate to ask around, e.g. via Launchpad Answers or the forum if you need help for publishing your changes.
-- 
https://code.launchpad.net/~openerp-community/openobject-addons/elico-6.0/+merge/49599
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/elico-6.0.