← Back to team overview

openerp-community team mailing list archive

Re: lp:~openerp-community/openobject-client/zehk_use-of-xdg-open into lp:openobject-client

 

Hi,

I'm interested in sorting out this bug and have followed this thread. I think the rewrite of the module might be too much, but the original proposition was pretty good as it didn't introduce any regression (not modifying too much code) and worked.
xdg-open is part of XdgUtils which make it simpler for an application to use the correct program to open any given file or URL (http://portland.freedesktop.org/wiki/). OpenERP GTK Client uses xdg-open only for pdf file and an intern list for others application. When it doesn't find the right application it just crash. The first proposition keeps the original solution while adding the correct way of opening a file under operating systems that respect freedesktop and user's preferences.

Of course a rewrite is needed for this module, using a generic file opener (xdg-open) and not for others files shows a lack of understanding of what does xdg-open.

Maybe the first proposition should be merged in stable branch as first easy step : it correct a bug under Debian (and maybe others distributions) and does not introduce any regression and the last proposition should be made a basis for a new correct code for opening a file.

My 2 cents.
Etienne.
-- 
https://code.launchpad.net/~openerp-community/openobject-client/zehk_use-of-xdg-open/+merge/77333
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-client/zehk_use-of-xdg-open.


References