openerp-community team mailing list archive

[Colin MacMillan <colin@xxxxxxxxxxxxxxxxxxxxxx>]

Hi Olivier, glad to hear you have tested the module.  The inheritance
approach was looked at but we decided against it ... perhaps we will
review it now as this is a good idea.

Regarding the testing, we tested it with our own scenarios and also got
help from other openerp partners.  The module is in 8 different live
implementations all using multi-currency so we are happy with the
accuracy.  To be honest I've not yet work out how to do YAML tests and it
is very technical and can I say 'geeky'.  Personally I'd rather use a
spreadsheet with figures I know are correct, then test this out on a
system manually.

We are keeping an eye on the 6.1 version which is much better for
multi-currency but still varies significantly from a usability standpoint.

Your viewpoints are appreciated.

Regards
Colin




-----Original Message-----
From: Olivier Dony [mailto:odo@xxxxxxxxxxx]
Sent: 22 November 2011 10:10
To: Colin MacMillan
Cc: openerp-community@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Openerp-community] new account_voucher available now

On 11/18/2011 01:15 PM, Colin MacMillan wrote:
> This module has a number of additional features:
>
> - speed - on_change has been replaced with a button for retrieving
> open lines
>
> - ergonomics - the layout and ability to select lines with a tick box
> makes the screen very easy to use
>
> - the new approach is not top-down, but bottom-up in design which is
> more intuitive for the operator.  Total appears at the bottom.
>
> - credit and invoice lines appear in different colours on the same
> list which is more logical
>
> - fully functional multi-currency - has already undergone heavy
> testing
>
> - 4 configurable accounts for write-off gain/losses and exchange rate
> gains/losses
>
> - enhanced cancellation process - fixes error in logic that meant
> partial payments would be retrospectively unreconciled automatically

Great job, your module seems to work nicely and introduces interesting
ideas.

One question pops immediately: why not building it as an extension of the
original account_voucher module, instead of duplicating the functionality?

I did not check thoroughly, but it seems you copied enough of the original
account_voucher module to stay compatible with the rest of the system. So
presumably this could also be achieved with an inheriting module, possibly
after refactoring some parts of the core that are currently hard to
inherit, and fixing any remaining bugs.
Your module would then be compatible with the official ones, simply
providing a variation on the workflow and screens of the original
account_voucher.

I suppose you have tried both approaches, so I would be interested to know
how hard you think it would be to go the inheriting route, imagining your
module as "account_voucher_alternative_layout", if you see what I mean.

BTW, did you compare your module with the trunk/6.1 version of
account_voucher, or only with 6.0?

And one last question, if I may: there do not seem to be any YAML
scenarios/test in the source of your module, so what strategy did you use
when you say it "has already undergone heavy testing"?

Thanks!